Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue] RHPAM-3709: upgrade maven dependencies to address CVE-2021-26291 #2407

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

baldimir
Copy link
Member

Replaces #2398

@baldimir
Copy link
Member Author

jenkins retest this

@mareknovotny
Copy link
Member

could it be here some problems with transitive deps of ShrinkWrap?

java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.jbpm.test.container.AbstractEJBTransactionsTest.deployEJBTest()
Caused by: java.lang.reflect.InvocationTargetException
Caused by: org.jboss.shrinkwrap.resolver.api.Invokable$InvocationException: Unable to invoke onlyOne([Ljava.lang.Class;@7f9e1534) on object org.jboss.shrinkwrap.resolver.spi.loader.ServiceRegistry with parameters [Ljava.lang.Object;@138a7441
Caused by: java.lang.reflect.InvocationTargetException
Caused by: java.lang.RuntimeException: Could not create new service instance
Caused by: java.lang.reflect.InvocationTargetException
Caused by: java.lang.NoClassDefFoundError: org/eclipse/aether/internal/impl/DefaultDependencyCollector

in https://github.com/baldimir/jbpm/blob/RHPAM-3709/jbpm-container-test/jbpm-in-container-test/jbpm-container-test-suite/pom.xml#L192-L231 ?

@elguardian
Copy link
Member

skinwrap depends on maven resolver impl that depens on aehter. this is not included in the pom.
I don't see how you want to workaround this
@baldimir

<version.org.jboss.shrinkwrap.resolver>3.1.0</version.org.jboss.shrinkwrap.resolver>
<version.org.jboss.shrinkwrap.resolver>3.3.0</version.org.jboss.shrinkwrap.resolver>
<version.org.apache.maven>3.9.3</version.org.apache.maven>
<version.org.apache.maven.resolver>1.9.13</version.org.apache.maven.resolver>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed guava
<version.com.google.guava>20.0</version.com.google.guava>

@mareknovotny
Copy link
Member

Jenkins retest this please

@mareknovotny
Copy link
Member

ok, now there are only 3 failed tests in comparison to 16 failures previously.

All 3 have the same root cause:

java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.Archive org.jbpm.test.container.test.WebServiceInvokeTest.deployWebService()
	at org.jbpm.test.container.test.WebServiceInvokeTest.deployWebService(WebServiceInvokeTest.java:49)
Caused by: java.lang.reflect.InvocationTargetException
	at org.jbpm.test.container.test.WebServiceInvokeTest.deployWebService(WebServiceInvokeTest.java:49)
Caused by: java.lang.RuntimeException: Could not create new service instance
	at org.jbpm.test.container.test.WebServiceInvokeTest.deployWebService(WebServiceInvokeTest.java:49)
Caused by: java.lang.reflect.InvocationTargetException
	at org.jbpm.test.container.test.WebServiceInvokeTest.deployWebService(WebServiceInvokeTest.java:49)
Caused by: com.google.inject.ProvisionException: 
Unable to provision, see the following errors:

1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot access session scope outside of a scoping block
  at ClassRealm[maven, parent: ClassRealm[maven-parent, parent: null]] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule -> org.apache.maven.session.scope.internal.SessionScopeModule)
  while locating org.apache.maven.execution.MavenSession

1 error
	at org.jbpm.test.container.test.WebServiceInvokeTest.deployWebService(WebServiceInvokeTest.java:49)
Caused by: com.google.inject.OutOfScopeException: Cannot access session scope outside of a scoping block
	at org.jbpm.test.container.test.WebServiceInvokeTest.deployWebService(WebServiceInvokeTest.java:49)

@elguardian
Copy link
Member

  • some notes in here. The error is a bit random and happens if you execute all the test in the suite. In local I managed to get 2 of them.

[ERROR] Errors:
[ERROR] RestServiceInvokeTest.org.jbpm.test.container.test.RestServiceInvokeTest » Runtime
[ERROR] TransactionsTest.org.jbpm.test.container.test.TransactionsTest » Runtime Could...

seems like an error in the clean up

@elguardian
Copy link
Member

elguardian commented Mar 27, 2024

Tested in my local seems a class loading problem
in failsafe

<reuseForks>false</reuseForks>
<forkCount>1</forkCount>
<useSystemClassLoader>false</useSystemClassLoader>

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mareknovotny mareknovotny merged commit 211671f into kiegroup:7.67.x-blue Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants