Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10234] CancelNode should be able to cancel more than one instance #2427

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

fjtirado
Copy link
Contributor

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@fjtirado fjtirado requested a review from gmunozfe June 24, 2024 17:22
@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jun 24, 2024
@fjtirado
Copy link
Contributor Author

jenkins run fdb

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test failure at
/src/test/java/org/jbpm/test/functional/event/BoundaryEventWithOutputSetPersistenceTest.java line 289:

expected null, but was:<_2>

It expects that node is removed but now it isn´t. @fjtirado can you check?

@fjtirado fjtirado force-pushed the JBPM-10234 branch 3 times, most recently from fc2ab68 to fdf496e Compare June 25, 2024 09:43
@fjtirado
Copy link
Contributor Author

There's a test failure at /src/test/java/org/jbpm/test/functional/event/BoundaryEventWithOutputSetPersistenceTest.java line 289:

expected null, but was:<_2>

It expects that node is removed but now it isn´t. @fjtirado can you check?

Yes, PR updated, good catch!

@fjtirado
Copy link
Contributor Author

jenkins run fdb

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, top-notch work @fjtirado !

Copy link

sonarcloud bot commented Jun 25, 2024

@fjtirado fjtirado merged commit f768ebb into kiegroup:main Jun 26, 2024
2 of 4 checks passed
fjtirado added a commit that referenced this pull request Jun 27, 2024
…ce (#2427) (#2430)

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
fjtirado added a commit that referenced this pull request Jun 27, 2024
…ce (#2427) (#2429)

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants