Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incubator-kie-issues#1049] Add index to ProcessInstanceLog table to improve LogCleanupCommand performance #2432

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[incubator-kie-issues#1049] Add index to ProcessInstanceLog table to improve LogCleanupCommand performance #2432

merged 2 commits into from
Jul 29, 2024

Conversation

martinweiler
Copy link
Contributor

@martinweiler martinweiler self-assigned this Jul 12, 2024
@akumar074
Copy link
Member

Jenkins run fdb

elguardian
elguardian approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elguardian
Copy link
Member

Jenkins retest this pleases.

@akumar074
Copy link
Member

Jenkins run fdb

@akumar074
Copy link
Member

Jenkins retest this

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@akumar074
Copy link
Member

Jenkins retest this

@akumar074
Copy link
Member

Hello @martinweiler @elguardian There are 5 test failures which are common in both FDB and PR checks and seems related with the change. Please take a look at it.

@akumar074 akumar074 added the backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch label Jul 22, 2024
@akumar074
Copy link
Member

Jenkins run fdb

2 similar comments
@akumar074
Copy link
Member

Jenkins run fdb

@akumar074
Copy link
Member

Jenkins run fdb

@elguardian
Copy link
Member

@akumar074 this is work and good to go.

@akumar074 akumar074 merged commit c546ff4 into kiegroup:main Jul 29, 2024
2 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@martinweiler
[incubator-kie-issues#1049] Add index to ProcessInstanceLog table to …
4f739f2 
…improve LogCleanupCommand performance (#2432)

* [incubator-kie-issues#1049] Add index to ProcessInstanceLog table to improve LogCleanupCommand performance

* Omit new index in H2 as it lacks support for filtered index
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Merged
akumar074 pushed a commit that referenced this pull request Jul 29, 2024
@github-actions @martinweiler
[incubator-kie-issues#1049] Add index to ProcessInstanceLog table to …
6c49a4f 
…improve LogCleanupCommand performance (#2432) (#2434)

* [incubator-kie-issues#1049] Add index to ProcessInstanceLog table to improve LogCleanupCommand performance

* Omit new index in H2 as it lacks support for filtered index

Co-authored-by: Martin Weiler <mweiler@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pefernan pefernan pefernan approved these changes

@elguardian elguardian elguardian approved these changes

Assignees

@martinweiler martinweiler

Labels
backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add index to ProcessInstanceLog table to improve LogCleanupCommand performance
4 participants
@martinweiler @akumar074 @elguardian @pefernan