Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue JBPM-10238 adding case insensitive comparison for entity #2435

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

sudhishmk
Copy link
Contributor

Added case insensitive comparison to fix this issue

Fix-: added a new property "ldap.entity.ignore.case", if set to true, will do case insensitive comparison, default value is false to ensure backward compatibility.

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@elguardian
Copy link
Member

@fjtirado @gmunozfe this looks ok, but up to you

Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just style suggestion, I think the code was calling for use of ternary operator there

@gmunozfe
Copy link
Member

gmunozfe commented Aug 5, 2024

jenkins test this

@gmunozfe
Copy link
Member

gmunozfe commented Aug 5, 2024

jenkins do fdb

@gmunozfe gmunozfe added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Aug 5, 2024
@gmunozfe
Copy link
Member

gmunozfe commented Aug 6, 2024

jenkins test this

@gmunozfe
Copy link
Member

gmunozfe commented Aug 6, 2024

jenkins do fdb

@gmunozfe
Copy link
Member

gmunozfe commented Aug 6, 2024

jenkins test this

@gmunozfe
Copy link
Member

gmunozfe commented Aug 6, 2024

jenkins do fdb

@gmunozfe
Copy link
Member

gmunozfe commented Aug 6, 2024

jenkins test this

1 similar comment
@gmunozfe
Copy link
Member

gmunozfe commented Aug 7, 2024

jenkins test this

@sudhishmk
Copy link
Contributor Author

jenkins do fdb

@sudhishmk
Copy link
Contributor Author

@gmunozfe Do I have to make any changes to fix FDB failure?

@gmunozfe
Copy link
Member

jenkins do fdb

@gmunozfe
Copy link
Member

@gmunozfe Do I have to make any changes to fix FDB failure?

@sudhishmk I have relaunched because it was failing due to PRs not merged before (there should be working now), let's see

@fjtirado fjtirado merged commit 713f191 into kiegroup:main Oct 17, 2024
1 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
#2435)

* Fix for issue JBPM-10238 adding case insensitive comparison for entity

* Fix for issue JBPM-10238 adding case insensitive comparison for entity
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
#2435)

* Fix for issue JBPM-10238 adding case insensitive comparison for entity

* Fix for issue JBPM-10238 adding case insensitive comparison for entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants