Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to cancel timer always, and only search if timer cancellation fails #2441

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Try to cancel timer always, and only search if timer cancellation fails #2441

wants to merge 2 commits into from

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Aug 27, 2024 •
edited
Loading

Try to cancel timer if the referene is available regardless of the failure. If timer cancellation fails and it is an interval trigger, try to search the timer reference to cancel through the db

@fjtirado fjtirado requested a review from gmunozfe August 27, 2024 15:11
@gmunozfe
Copy link
Member

jenkins do fdb

gmunozfe
gmunozfe approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work @fjtirado !

@krisv krisv requested a review from gmunozfe September 11, 2024 12:02
gmunozfe
gmunozfe approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your work @krisv , it's a weird scenario and this should make the code more robust by skipping the searching also in case there's no exception caught.

@mareknovotny
Copy link
Member

jenkins do fdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fjtirado @gmunozfe @mareknovotny @krisv