Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-422] move admin user/pwd to statusDescriptors #508

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tchughesiv
Copy link
Member

@tchughesiv tchughesiv commented Sep 21, 2020

Dependant on openshift/console#6697

We'll need to wait for a later operator release. Once the above is merged. Then, we'll need to target the operator version that aligns with whatever OCP version these console password type enhancements are released with. Which appears to be 4.7.

Screen Shot 2020-09-21 at 11 06 42 AM

Signed-off-by: tchughesiv tchughesiv@gmail.com

@openshift-ci-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bmozaffa
Copy link
Collaborator

What happened here? Did you change your strategy RE displaying the default RedHat password to users?

@tchughesiv
Copy link
Member Author

tchughesiv commented Sep 21, 2020

What happened here? Did you change your strategy RE displaying the default RedHat password to users?

@bmozaffa yes... further testing reveals that randomly generated passwords (the most important ones to display) are in status only.

unfortunately, the password type is not currently supported in statusDescriptors... so i've submitted a PR to add it.
openshift/console#6697

@bmozaffa
Copy link
Collaborator

/lgtm

@bmozaffa
Copy link
Collaborator

/lgtm

@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

Signed-off-by: tchughesiv <tchughesiv@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@openshift-ci-robot
Copy link
Collaborator

@tchughesiv: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Base automatically changed from master to main January 26, 2021 19:51
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2021

@tchughesiv: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/lint 998eb09 link /test lint
ci/prow/vet 998eb09 link /test vet
ci/prow/format 998eb09 link /test format
ci/prow/images 998eb09 link /test images
ci/prow/configs 998eb09 link /test configs
ci/prow/mod 998eb09 link /test mod
ci/prow/unit 998eb09 link /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mareknovotny
Copy link
Member

i guess we can close this as outdated, right @tchughesiv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants