Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kernel's define_singleton_method patch #372

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

hmnhf
Copy link
Contributor

@hmnhf hmnhf commented Jul 31, 2023

Copy link
Member

@pierre pierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

To give additional colour, this was required to support legacy Rails applications, as we used to only provide the kaui gem as a mountable engine. Nowadays, users should instead consume the standalone Kaui application, which supports various forms of customizations.

@pierre pierre merged commit 985e5c9 into killbill:master Jul 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants