lifecycle: Introduce a LifecycleConfig. See killbill/killbill#1911 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a first use case to configure our lifecycle to decide whether system should exit when some plugins fail to start.
pierre
reviewed
Dec 2, 2023
There was a problem hiding this comment.
Looks like tests need some additional Guice wiring.
@reshmabidikar Let's not forget to update our config docs.
| if (exitOnError) { | ||
| log.info("{} is set, so exiting..", EXIT_ON_LIFECYCLE_ERROR_PROPERTY); | ||
| if (config.isServerExitOnLifecycleError()) { | ||
| log.warn("Existing as system was configured to exist on lifecycle error "); |
reshmabidikar
approved these changes
Dec 4, 2023
|
Looks like there are some test failures though. CI is red. |
Fixed in 0f4f895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a first use case to configure our lifecycle to decide whether system should exit when some plugins fail to start.