Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maven release problem #159

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix maven release problem #159

merged 1 commit into from
Mar 15, 2024

Conversation

xsalefter
Copy link
Contributor

The problem discussed here. From Pierre:

There is this annoying bug by the maven release plugin which introduces whitespace changes when it makes a release. I suspect if you run mvn install locally, you will see whitespace changes. You need to commit them before being able to do the release

Copy link
Member

@sbrossie sbrossie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the difference - is this about removing the extra space that we have before /> ?

@sbrossie
Copy link
Member

I don't really understand the difference - is this about removing the extra space that we have before /> ?

@sbrossie sbrossie closed this Mar 15, 2024
@sbrossie sbrossie reopened this Mar 15, 2024
@sbrossie
Copy link
Member

I don't really understand the difference - is this about removing the extra space that we have before /> ?

Ok, I understand now... if's very confusing what this hows up and why just this package. Happy to merge if this helps.

@sbrossie sbrossie merged commit 441a1d1 into master Mar 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants