Add code to support log group tagging #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislyuk
approved these changes
Jun 20, 2024
|
Thanks! |
|
Please do not ignore CI failures. I did not look carefully because I assumed that the CI failures were due to AWS credential issues, but this PR had linting and typing errors. |
kislyuk
added a commit
that referenced
this pull request
Aug 21, 2024
kislyuk
added a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tags to the log group using a parameter when instantiating the CloudWatchLogHandler. Included are:
(Note: I tried to use
addCleanup()to delete the log group associated with the test after it is complete, but test runs kept giving a runtime error that the log stream did not exist. This is likely a race condition somewhere working with AWS so I removed the cleanup function.)