-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New addon setup #16
New addon setup #16
Conversation
@ericof I moved the add-on to the cookieplone template, and CI is yelling at me at coverage and circular... why? |
@sneridagh I fixed the coverage check and disabled the circular check (it's complaining about cycles in Plone core) but there are some other things that aren't ready yet. |
@davisagli sorry for the crappy PR, I stopped working on it when I saw all the issues in CI, now should be ready for review! Regarding the support for 5.2, no clue if we can do that with mxdev in an easy way, so I would tend to remove support. Regarding the tests, I'm still not comfortable with pytest tests, maybe it's time for you and @ericof to make a small training session to all the team. Also, the existing couple of tests were quite basic. Let's talk this evening. |
@sneridagh @davisagli if supporting Plone 5.2 requires us to put effort into it, let's drop the support and do a major version bumb. If we need Plone 5.2 we can still use the old version and even make new releases in that branch if necessary. |
@sneridagh we need to add two test dependencies to make the CI pass:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking a lot better now, but I don't want to lose the tests.
@tisto @sneridagh Actually we already stopped supporting Plone 5 in version 2.0.0, according to the changelog. |
No description provided.