Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New addon setup #16

Merged
merged 15 commits into from
May 21, 2024
Merged

New addon setup #16

merged 15 commits into from
May 21, 2024

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh requested review from ericof and tisto May 20, 2024 09:38
@sneridagh
Copy link
Member Author

@ericof I moved the add-on to the cookieplone template, and CI is yelling at me at coverage and circular... why?

README.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
src/kitconcept/seo/controlpanel/configure.zcml Outdated Show resolved Hide resolved
src/kitconcept/seo/events.py Outdated Show resolved Hide resolved
src/kitconcept/seo/serializers/summary.py Outdated Show resolved Hide resolved
src/kitconcept/seo/testing.py Outdated Show resolved Hide resolved
src/kitconcept/seo/tests/test_behaviors_seo.py Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

@sneridagh I fixed the coverage check and disabled the circular check (it's complaining about cycles in Plone core) but there are some other things that aren't ready yet.

@sneridagh
Copy link
Member Author

@davisagli sorry for the crappy PR, I stopped working on it when I saw all the issues in CI, now should be ready for review!

Regarding the support for 5.2, no clue if we can do that with mxdev in an easy way, so I would tend to remove support.

Regarding the tests, I'm still not comfortable with pytest tests, maybe it's time for you and @ericof to make a small training session to all the team. Also, the existing couple of tests were quite basic.

Let's talk this evening.

@tisto
Copy link
Member

tisto commented May 21, 2024

@sneridagh @davisagli if supporting Plone 5.2 requires us to put effort into it, let's drop the support and do a major version bumb. If we need Plone 5.2 we can still use the old version and even make new releases in that branch if necessary.

@tisto
Copy link
Member

tisto commented May 21, 2024

@sneridagh we need to add two test dependencies to make the CI pass:

Requirements that should be test requirements
=============================================
     plone.app.contenttypes
     plone.restapi

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking a lot better now, but I don't want to lose the tests.

src/kitconcept/seo/tests/test_behaviors_seo.py Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

@tisto @sneridagh Actually we already stopped supporting Plone 5 in version 2.0.0, according to the changelog.

@davisagli davisagli merged commit 8819a77 into main May 21, 2024
6 checks passed
@davisagli davisagli deleted the newaddonsetup branch May 21, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants