[FEATURE] Integrate media player from slub_web_sachsendigital #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albig
changed the title
dvoracek-slub
force-pushed
the
dev-mediaplayer
branch
from
405e225
to
c7cc542
Compare
dvoracek-slub
force-pushed
the
dev-mediaplayer
branch
2 times, most recently
from
83d73e7
to
27efea0
Compare
dvoracek-slub
force-pushed
the
dev-mediaplayer
branch
from
27efea0
to
2f56878
Compare
added 21 commits
August 23, 2022 19:32
Based upon commit slub/slub_web_sachsendigital#6e68a11
- Adopt build system from `slub_web_sachsendigital` - Use player in plugin - In Table of Contents, link to timecodes - Make element ID configurable
added 10 commits
August 23, 2022 19:42
This will allow to give more information needed for cross-file links.
- Better handling of Shift modifiers (don't list it in keybindings.json, and don't show it in help modal when obvious) - On Mac, use Option key, and display variants appropriately - Add more common "?" key for help modal
dvoracek-slub
force-pushed
the
dev-mediaplayer
branch
from
2f56878
to
5743dca
Compare
added 13 commits
August 29, 2022 21:08
Previously, positioning of the seek bar relied on box-sizing coming from `slub_digitalcollections`.
dvoracek-slub
force-pushed
the
dev-mediaplayer
branch
from
5743dca
to
21f947b
Compare
sebastian-meyer
added
the
⏳ prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the video/audio player from
slub_web_sachsendigitalinto a new MediaPlayer plugin. The PR is based on #796.For testing this within the DFG Viewer, I have prepared a DDEV system at https://github.com/dvoracek-slub/ddev-dfgviewer-dist/tree/mediaplayer. It relies on https://github.com/dvoracek-slub/dfg-viewer/tree/dev-mediaplayer and includes a demo METS video document.
There also is a work-in-progress section in the documentation that describes some features and technical aspects of the player.
composer docs:servecan be used for local preview.Update (2022-07-06). Most notable changes:
Modsformat class. I use this to test GND linking of some audio-related metadata.