-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#minor Add an option to send request only once per batch #356
base: master
Are you sure you want to change the base?
Conversation
Hi @ahtohio, thx for contributing. I like your reload idea to save cpu time. Changes looks good to me so far. Do you have any ideas about whether the function can be included into the tests? |
Hi, @ChristianGeie |
thx @ahtohio . I do a lot of changes regarding workflow actions in the last couple of weeks, please excuse that sometimes the tests didn't work reliably. |
Hi, @ChristianGeie, it seems all's good, only approval left |
@ChristianGeie this is a pretty important fix in my opinion, my 12 core CPU gets hammered while running our application. If there is anything I can do to progress this PR, please let me know. |
Reloading on each received event (with watch method) can be quite costly. I run Grafana provisioning and asking it to reload all my provisioned configmaps (>300) on each event is not needed and only increases cpu load.
Reload once after each WATCH_SERVER_TIMEOUT seconds should be enough.
I've added an option REQ_ONCE_PER_BATCH that can toggle this reload-once-per-watch-cycle reload behaviour, false by default to not interfere with existing logic.