Skip to content

Commit

Permalink
chore: Remove commented code for adding rar extension
Browse files Browse the repository at this point in the history
This commit removes the commented code for adding the rar extension in the macOS workflow. The code was previously used to clone the php-rar repository, configure and install the extension, and update the necessary configuration files. However, it is no longer needed and has been commented out.

Note: Please remove any meta information like issue references, tags, or author names from the commit message.
  • Loading branch information
ewilan-riviere committed Jul 28, 2024
1 parent 9ef9d0a commit 2cb0f54
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions .github/workflows/run-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@ jobs:
brew install imagemagick
shell: bash

- name: Add rar extension
run: |
git clone https://github.com/cataphract/php-rar
cd php-rar
phpize
./configure
sudo make
sudo make install
pecl_path=$(pecl config-get ext_dir)
phpini_path=$(php -i | grep /.+/php.ini -oE)
sudo cp ./modules/rar.so $pecl_path
sudo echo "extension=rar.so" > $phpini_path
# - name: Add rar extension
# run: |
# git clone https://github.com/cataphract/php-rar
# cd php-rar
# phpize
# ./configure
# sudo make
# sudo make install
# pecl_path=$(pecl config-get ext_dir)
# phpini_path=$(php -i | grep /.+/php.ini -oE)
# sudo cp ./modules/rar.so $pecl_path
# sudo echo "extension=rar.so" > $phpini_path

- name: Setup problem matchers
run: |
Expand All @@ -48,8 +48,8 @@ jobs:
- name: Install dependencies
run: composer update --prefer-dist --no-interaction

- name: Check extension rar
run: php -m | grep rar
# - name: Check extension rar
# run: php -m | grep rar

- name: Check extension imagick
run: php -m | grep imagick
Expand Down

0 comments on commit 2cb0f54

Please sign in to comment.