Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.0 #58

Merged
merged 6 commits into from
Jan 22, 2024
Merged

v2.3.0 #58

merged 6 commits into from
Jan 22, 2024

Conversation

ewilan-riviere
Copy link
Contributor

Drop kiwilan/php-audio dependency.

Audiobooks are cool, but I suppose many users don't need it. So I think it's better to drop kiwilan/php-audio dependency, you have to install kiwilan/php-audio manually.
If you scan audiobooks without kiwilan/php-audio installed, you will get an error message.

@ewilan-riviere ewilan-riviere merged commit 383e87b into main Jan 22, 2024
13 checks passed
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (24c597e) 90.52% compared to head (82e0619) 90.50%.
Report is 17 commits behind head on main.

Files Patch % Lines
src/Formats/Audio/AudiobookModule.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #58      +/-   ##
============================================
- Coverage     90.52%   90.50%   -0.03%     
- Complexity      734      736       +2     
============================================
  Files            30       30              
  Lines          2312     2317       +5     
============================================
+ Hits           2093     2097       +4     
- Misses          219      220       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant