Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.1 #59

Merged
merged 4 commits into from
Jan 27, 2024
Merged

v2.3.1 #59

merged 4 commits into from
Jan 27, 2024

Conversation

ewilan-riviere
Copy link
Contributor

Deprecated some MetaTitle methods getSlugSort(), getSlugUnique(), getSerieSlug(), getSerieSlugSort(), getSerieSlugUnique(), getSlugSortWithSerie(), getUniqueFilename(). Now only getSlug(), getSlugSimple(), getSeriesSlug(), getSeriesSlugSimple() are available.

Slug have to be unique, so default slug take some metadata to be unique, like in this example:

An EPUB with title La pâle lumière des ténèbres with main author Pierre Bottero, series A comme Association, volume 1, language fr and published in 1980 will have the slug pale-lumiere-des-tenebres-a-comme-association-01-1980-pierre-bottero-epub-fr.

You can use getSlugSimple() to have a simple slug, like pale-lumiere-des-tenebres.

For series, you can use getSeriesSlug() to have a slug with series name, like a-comme-association-1980-pierre-bottero-epub-fr.

And getSeriesSlugSimple() to have a simple slug with series name, like a-comme-association.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (82e0619) 90.50% compared to head (1e250e0) 89.90%.
Report is 12 commits behind head on main.

Files Patch % Lines
src/Tools/MetaTitle.php 84.61% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #59      +/-   ##
============================================
- Coverage     90.50%   89.90%   -0.61%     
- Complexity      736      740       +4     
============================================
  Files            30       30              
  Lines          2317     2308       -9     
============================================
- Hits           2097     2075      -22     
- Misses          220      233      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewilan-riviere ewilan-riviere merged commit c3ca21d into main Jan 27, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant