-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Select All Option to Multi-Zim Search Options #1234
Draft
ShaopengLin
wants to merge
13
commits into
main
Choose a base branch
from
Issue#315-select-all-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User can search zim other than the current tab.
Shortcut and Icon for MultiZim. Since window is popup, toggle is not possible.
Decouple complex item creation from button. Used later for styling.
Missing this reason cause completer to do nothing
Previously only checks when clicking Radiobutton
Set height&padding for list&items and stretch to menu width.
Helper function to retrieve text content that can fit inside a length given a custom "(...)" elide.
Add Custom elide marker
With MultiZim, searching on library, settings, and blank tabs are reasonable.
QCheckbox does not provide support out of the box for key press checking.
ShaopengLin
force-pushed
the
Issue#413-multizim
branch
from
November 3, 2024 17:31
7fe06f5
to
1d533a3
Compare
kelson42
force-pushed
the
Issue#413-multizim
branch
from
November 4, 2024 09:16
1d533a3
to
5922f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix (part of) #315
Changes: