Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt kiwix-desktop to new libkiwix API. #894

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adapt kiwix-desktop to new libkiwix API. #894

wants to merge 2 commits into from

Commits on Oct 18, 2022

  1. Move the server management in kiwixapp. 

    `LocalKiwixServer` is "just" a UI to start/configure or stop the server.

One important change is that instead of having one server we configure and
start/stop when needed, we are now creating a new server each time
we want to start the server.

It doesn't change the behavior, as libkiwix is destroying/recreating for
us, but it will help us to use the new API which use a
`Server::Configuration`.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    9a9e581 View commit details
    Browse the repository at this point in the history

  2. Addapt kiwix desktop to last libkiwix API. 

    Now libkiwix `Manipulator`, `Server`, `NameMapper`, ... take shared_ptr.
We have to store all those object using shared_ptr instead of as plain
object.
    @mgautierfr
    mgautierfr committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    650b803 View commit details
    Browse the repository at this point in the history