Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable KLib ABI validation #566

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jul 24, 2024

@Goooler Goooler marked this pull request as draft July 24, 2024 03:50
@Goooler
Copy link
Contributor Author

Goooler commented Jul 24, 2024

Seems there is a bug in BCV:

* What went wrong:
Execution failed for task ':compose-multiplatform:library:klibApiCheck'.
> API check failed for project library.

  --- /home/runner/work/Calendar/Calendar/compose-multiplatform/library/build/api/klib-all/extracted/library.klib.api
  +++ /home/runner/work/Calendar/Calendar/compose-multiplatform/library/build/api/klib/library.klib.api
  @@ -5,7 +5,7 @@
   // - Show manifest properties: true
   // - Show declarations: true
   
  -// Library unique name: <kizitonwose-calendar.compose-multiplatform:library>
  +// Library unique name: <Calendar.compose-multiplatform:library>
   final enum class com.kizitonwose.calendar.compose.heatmapcalendar/HeatMapWeekHeaderPosition : kotlin/Enum<com.kizitonwose.calendar.compose.heatmapcalendar/HeatMapWeekHeaderPosition> { // com.kizitonwose.calendar.compose.heatmapcalendar/HeatMapWeekHeaderPosition|null[0]
       enum entry End // com.kizitonwose.calendar.compose.heatmapcalendar/HeatMapWeekHeaderPosition.End|null[0]
       enum entry Start // com.kizitonwose.calendar.compose.heatmapcalendar/HeatMapWeekHeaderPosition.Start|null[0]
  @@ -364,6 +364,12 @@
       final fun toString(): kotlin/String // com.kizitonwose.calendar.data/WeekDateRange.toString|toString(){}[0]
   }

https://github.com/kizitonwose/Calendar/actions/runs/10070165332/job/27838250741?pr=566

@Goooler
Copy link
Contributor Author

Goooler commented Jul 24, 2024

Filed to Kotlin/binary-compatibility-validator#261.

@Goooler Goooler marked this pull request as ready for review August 13, 2024 00:21
@@ -32,3 +32,5 @@ include(":compose")
include(":sample")
include(":compose-multiplatform:library")
include(":compose-multiplatform:sample")

rootProject.name = "Calendar"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@kizitonwose kizitonwose merged commit f0ddb81 into kizitonwose:main Aug 15, 2024
6 checks passed
@Goooler Goooler deleted the enable-abi-dump branch August 16, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants