Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppeteer v14.1.1 on macOS 12.4 M1 Pro
Saw the error below when calling
fakeBrowser.shutdown()
, caused by the puppeteer’sBrowserRunner
code trying to kill the process group when FakeBrowser had already killed all its PIDs.This commit changes the order to call
browser.close()
before killing the process tree. You may also choose to simply remove the process killing code since puppeteer already does that.