Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Improve readme #130

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Doc: Improve readme #130

merged 4 commits into from
Sep 21, 2023

Conversation

khaeljy
Copy link
Contributor

@khaeljy khaeljy commented Sep 20, 2023

Time spent on this PR: 30m

Resolves: N/A

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

I've added a bit of context to the README to help new contributors (like me).

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of clarifications, feel free to let me know if you agree, otherwise thanks for the PR!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Eikix
Eikix previously approved these changes Sep 21, 2023
@Eikix
Copy link
Member

Eikix commented Sep 21, 2023

thanks for the PR!:)

Co-authored-by: greged93 <82421016+greged93@users.noreply.github.com>
Co-authored-by: greged93 <82421016+greged93@users.noreply.github.com>
@khaeljy
Copy link
Contributor Author

khaeljy commented Sep 21, 2023

just a couple of clarifications, feel free to let me know if you agree, otherwise thanks for the PR!

thank you for these details 😉

@Eikix Eikix merged commit a1747cb into kkrt-labs:main Sep 21, 2023
4 checks passed
@khaeljy khaeljy deleted the improve-readme branch September 21, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants