feat: contract class conversion #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
added this to the Q4-2023 - Continuous Improvement - Codebase Improvement milestone
|
The PR doesn't improve the current speed of execution and could introduce unwanted bugs. We will keep the serde_json method of conversion between the types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Time spent on this PR: 0.4 day
Resolves: #474
Please check the type of change your PR introduces:
What is the new behavior?
Implements conversion between the starknet rs contract class and the cairo-vm contract class, instead of using serde_json to serialize it and then deserialize it into another type.
Does this introduce a breaking change?