Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test logging #510

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

ClementWalter
Copy link
Member

Pull Request type

Time spent on this PR: 0.1

Resolves: #{Issue number}

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Cairo stack trace is displayed with line break.
When targeting a single test, no other tests are marked as Passed.
No redundant logging of the test run.

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greged93 greged93 added this pull request to the merge queue Oct 9, 2023
Merged via the queue into kkrt-labs:main with commit a0268e4 Oct 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants