feat: add dumping and loading of state #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
reviewed
Oct 23, 2023
greged93
reviewed
Oct 23, 2023
greged93
reviewed
Oct 23, 2023
|
Also, can you integrate all this in the actual execution of the tests? |
bajpai244
force-pushed
the
feat/add-serialization-to-state
branch
2 times, most recently
from
25a6b02 to
0ed55db
Compare
resolved via this. |
greged93
reviewed
Oct 27, 2023
|
What is the status of this @bajpai244 @greged93 |
|
CI failing and waiting for answer on comments |
bajpai244
force-pushed
the
feat/add-serialization-to-state
branch
2 times, most recently
from
82167c9 to
87faaf2
Compare
added 14 commits
November 1, 2023 17:07
bajpai244
force-pushed
the
feat/add-serialization-to-state
branch
from
af6efae to
3d27d5b
Compare
|
@bajpai244 you have a couple of issues in the trunk CI you need to fix |
bajpai244
force-pushed
the
feat/add-serialization-to-state
branch
from
3d27d5b to
e24c8ac
Compare
greged93
force-pushed
the
feat/add-serialization-to-state
branch
from
e24c8ac to
633cee0
Compare
|
I think we shouldn't have any diff on ef test folder |
Eikix
reviewed
Nov 2, 2023
Eikix
reviewed
Nov 2, 2023
Eikix
reviewed
Nov 2, 2023
Eikix
reviewed
Nov 2, 2023
Eikix
reviewed
Nov 2, 2023
Eikix
reviewed
Nov 2, 2023
Eikix
reviewed
Nov 2, 2023
Eikix
reviewed
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Time spent on this PR:
Resolves: #159
Please check the type of change your PR introduces:
What is the new behavior?
Allows dump and loading state to and from json files.
Does this introduce a breaking change?