Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: contributor guide #96

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Conversation

greged93
Copy link
Contributor

Time spent on this PR: 0.3 day

Resolves: #83

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@greged93 greged93 marked this pull request as draft September 11, 2023 11:05
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Great documentation

@jobez
Copy link
Contributor

jobez commented Sep 12, 2023

this is really good. can we include example issues created for each role?

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol changes

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm we could merge as is and improve as we go

@greged93
Copy link
Contributor Author

let's merge once I can bump the Katana and make the fixes, want to be sure launching testing is easy and PRs pass the CI.

@Eikix
Copy link
Member

Eikix commented Sep 19, 2023

let's rebase and merge?

@greged93 greged93 marked this pull request as ready for review September 19, 2023 08:54
@ClementWalter ClementWalter added this pull request to the merge queue Sep 19, 2023
Merged via the queue into kkrt-labs:main with commit 6a0ca02 Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: create documentation for the 3 roles for the ef-test track
4 participants