Skip to content

Commit

Permalink
take chain_id modulo u32 in account as well (#1085)
Browse files Browse the repository at this point in the history
<!--- Please provide a general summary of your changes in the title
above -->

<!-- Give an estimate of the time you spent on this PR in terms of work
days.
Did you spend 0.5 days on this PR or rather 2 days?  -->

Time spent on this PR:

## Pull request type

<!-- Please try to limit your pull request to one type,
submit multiple pull requests if needed. -->

Please check the type of change your PR introduces:

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying,
or link to a relevant issue. -->

Resolves #<Issue number>

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

-
-
-

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1085)
<!-- Reviewable:end -->
  • Loading branch information
Eikix authored Apr 8, 2024
1 parent 750d2a5 commit a9625be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/kakarot/accounts/library.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ namespace AccountContract {
let r = Uint256(tx_info.signature[0], tx_info.signature[1]);
let s = Uint256(tx_info.signature[2], tx_info.signature[3]);
let v = tx_info.signature[4];
let (_, chain_id) = unsigned_div_rem(tx_info.chain_id, 2 ** 64);
let (_, chain_id) = unsigned_div_rem(tx_info.chain_id, 2 ** 32);

EthTransaction.validate(
address,
Expand Down

0 comments on commit a9625be

Please sign in to comment.