feat: implement 0x4a: blob_base_fee #247
Open
+141
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
commented
Dec 10, 2024
obatirou
previously approved these changes
Dec 10, 2024
enitrat
force-pushed
the
feat/blobbasefee
branch
from
837cba5 to
f93ed0b
Compare
obatirou
reviewed
Dec 11, 2024
| local state: model.State*; | ||
| %{ block %} | ||
| %{ state %} | ||
| // Given |
There was a problem hiding this comment.
Suggested change
| // Given |
obatirou
reviewed
Dec 11, 2024
| def test_should_push_blob_base_fee(self, cairo_run): | ||
| block_ = block() | ||
| [blob_base_fee] = cairo_run( | ||
| "test__exec_blob_base_fee", block=block_, state=State.model_validate({}) |
There was a problem hiding this comment.
Why pass an empty State and call the %{ state %} hint ? Seems not necessary
You could add in the cairo code let state = State.init() directly
There was a problem hiding this comment.
I don't want to introduce reliance on the Cairo function to generate an empty state, I want to be able to pass any state from python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167