Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Constants #14

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Updated Constants #14

merged 1 commit into from
Apr 19, 2024

Conversation

holgergrote
Copy link
Contributor

With 2024.1 some Constants got deprecated and needed to be changed to the new definitions

With 2024.1 some Constants got deprecated and needed to be changed to the new definitions
@klacol
Copy link
Owner

klacol commented Apr 18, 2024

Ok, thanks for you contribution. What is the effect, if we do not change to the new definitions? I am just curious.

@holgergrote
Copy link
Contributor Author

holgergrote commented Apr 18, 2024

I got warnings in the logs about the constants. It also informs, that these constants will be removed in 2025.1.
So at the moment everything will work. You just get log warnings. It just should be changed till release 2025.1

I do not have the log entries anymore. They look the same like from other integrations.
Example issue with log informations: georgezhao2010/midea_ac_lan#463

I found a blog post about that change:
https://developers.home-assistant.io/blog/2023/12/19/constant-deprecation/

@klacol
Copy link
Owner

klacol commented Apr 19, 2024

Ah, I understand, thanks for this clarification.

@klacol klacol merged commit 259bc10 into klacol:master Apr 19, 2024
4 checks passed
@klacol
Copy link
Owner

klacol commented Apr 20, 2024

After merging, i have this error: #15
It maybe related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants