This repository has been archived by the owner on Feb 12, 2021. It is now read-only.
Fix withHoverProps
using onMouseEnter
and onMouseLeave
#52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
onMouseOver
andonMouseOut
bubbles up to the DOM triggering unnecessary re-renders every time you hover on any children of wrapped with this HOC component.onMouseEnter
andonMouseLeave
stops this madness and works just like "hover".See https://api.jquery.com/mouseenter/ and https://api.jquery.com/mouseleave/ for further details.
This is a breaking change because we need to change props mapping in every wrapped component (if it's not in
{...props}
ofc).