Update help message in SBK-RAM.

Signed-off-by: Keshava Munegowda <keshava.gowda@gmail.com>
kmgowda · Jun 17, 2021 · b6f13de · b6f13de
1 parent 58058f3
commit b6f13de
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/sbk-ram/src/main/java/io/sbk/ram/impl/SbkRam.java b/sbk-ram/src/main/java/io/sbk/ram/impl/SbkRam.java
@@ -25,6 +25,7 @@
 import io.sbk.perl.impl.NanoSeconds;
 import io.sbk.system.Printer;
 import org.apache.commons.cli.ParseException;
+import org.apache.commons.cli.UnrecognizedOptionException;
 
 import java.io.IOException;
 import java.util.Arrays;
@@ -165,11 +166,19 @@ private static Benchmark createBenchmark(final String[] args, final String appli
 
         params = new SbkRamParameters(appName, ramConfig.maxConnections);
         logger.addArgs(params);
-        params.parseArgs(args);
+        try {
+            params.parseArgs(args);
+            logger.parseArgs(params);
+        } catch (UnrecognizedOptionException ex) {
+            Printer.log.error(ex.toString());
+            params.printHelp();
+            throw new InstantiationException("print help !");
+        }
         if (params.hasOption("help")) {
+            params.printHelp();
             throw new InstantiationException("print help !");
         }
-        logger.parseArgs(params);
+
         TimeUnit timeUnit = logger.getTimeUnit();
         if (timeUnit == TimeUnit.mcs) {
             time = new MicroSeconds();

diff --git a/sbk-ram/src/main/java/io/sbk/ram/impl/SbkRamParameters.java b/sbk-ram/src/main/java/io/sbk/ram/impl/SbkRamParameters.java
@@ -15,6 +15,7 @@
 import lombok.Getter;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.cli.ParseException;
+import org.apache.commons.cli.UnrecognizedOptionException;
 
 
 /**
@@ -51,8 +52,7 @@ public void parseArgs(String[] args) throws ParseException, IllegalArgumentExcep
         storageName = getOptionValue("class", null);
 
         if (storageName == null) {
-            throw new IllegalArgumentException("storage class name is NOT supplied! " +
-                    ", run with '-help' to see the options.");
+            throw new UnrecognizedOptionException("storage 'class' name is NOT supplied! ");
         }
 
         String actionString = getOptionValue("action", "r");