Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing codeflask with code-input #2139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bowrna
Copy link
Contributor

@Bowrna Bowrna commented Nov 5, 2024

related: #2072

This is work in progress to replace codeflask with code-input for showing syntax highlighted text/code editor inside campaign content.

@Bowrna
Copy link
Contributor Author

Bowrna commented Nov 19, 2024

I have some css related issue in this PR. Let me try debugging and closing this issue before this weekends.

@Bowrna Bowrna marked this pull request as ready for review December 27, 2024 17:09
@Bowrna
Copy link
Contributor Author

Bowrna commented Jan 2, 2025

Could this PR be reviewed?
If there is any feedback, let me know.

@knadh
Copy link
Owner

knadh commented Jan 5, 2025

Hi @Bowrna. There seems to be several issues with this.

The HTML editor is completely broken. This is what I'm getting:
image

Referring ./node_modules/* in the frontend HTML file is not correct. All modules should be bundled in the JS compilation.

@Bowrna
Copy link
Contributor Author

Bowrna commented Jan 6, 2025

@knadh Let me fix this and update here. I missed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants