-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serving updates and istio doc (simple mode) #81
base: main
Are you sure you want to change the base?
Serving updates and istio doc (simple mode) #81
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: muscionig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @muscionig! It looks like this is your first PR to knative-extensions/autoscaler-keda 🎉 |
Hi @muscionig. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
065d2b6
to
7d6fe01
Compare
7d6fe01
to
6f32429
Compare
Changes
This PR mainly adds documentation for developing with
istio
and updates all versions ofserving
to the latest (v1.16.0
).(Please let me know if anything in this PR is not following guidelines, I reviewed them on the
serving
repo but it is possible I have missed something. Happy to make edits if required.)Minor Changes
serving
(and respective networking layers) tov1.16.0
.istio
to development guidelines, please see below for report on testing asDEVELOPMENT.md
contains examples only usingkourier
. While this contributes to Document support with Istio and MTLS #56, additional testing is required to enableinjection
.pullPolicy
so thatko.local
can be used underMinikube
(happy to revert if this is not preferred).istio
and clean up usage guide.istio
:before scaling:
During scaling:
Questions
@skonto would you like me to move forward in this PR and document also
injection
? I have a version working already, just though of splitting it as I wanted to also document some of those scaling from zero consideration we made on Slack./kind documentation
/kind cleanup
/kind enhancement