Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serving updates and istio doc (simple mode) #81

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

muscionig
Copy link
Contributor

Changes

This PR mainly adds documentation for developing with istio and updates all versions of serving to the latest (v1.16.0).

(Please let me know if anything in this PR is not following guidelines, I reviewed them on the serving repo but it is possible I have missed something. Happy to make edits if required.)

Minor Changes

  • 🎁 updates serving (and respective networking layers) to v1.16.0.
  • 🎁 adding istio to development guidelines, please see below for report on testing as DEVELOPMENT.md contains examples only using kourier. While this contributes to Document support with Istio and MTLS #56, additional testing is required to enable injection.
  • 🐛 change pullPolicy so that ko.local can be used under Minikube (happy to revert if this is not preferred).
  • 🧹 updated documentation listing istio and clean up usage guide.

istio:

before scaling:

$ kubectl get pod -A   
NAMESPACE         NAME                                                     READY   STATUS    RESTARTS      AGE
cert-manager      cert-manager-67c98b89c8-2qvqt                            1/1     Running   0             37m
cert-manager      cert-manager-cainjector-5c5695d979-wbhth                 1/1     Running   0             37m
cert-manager      cert-manager-webhook-7f9f8648b9-22wf5                    1/1     Running   0             37m
default           alertmanager-prometheus-kube-prometheus-alertmanager-0   2/2     Running   0             31m
default           metrics-test-00001-deployment-54b7f678f6-pfhng           2/2     Running   0             25m
default           prometheus-grafana-69f9ccfd8d-ztcd7                      3/3     Running   0             31m
default           prometheus-kube-prometheus-operator-6f4fc4dcbd-sz625     1/1     Running   0             31m
default           prometheus-kube-state-metrics-57c8464f66-rlshs           1/1     Running   0             31m
default           prometheus-prometheus-kube-prometheus-prometheus-0       2/2     Running   0             31m
default           prometheus-prometheus-node-exporter-wzcc6                1/1     Running   0             31m
istio-system      istio-ingressgateway-5f8bcfbff9-2sccm                    1/1     Running   0             33m
istio-system      istio-ingressgateway-5f8bcfbff9-q4zbn                    1/1     Running   0             33m
istio-system      istio-ingressgateway-5f8bcfbff9-qhqp5                    1/1     Running   0             33m
istio-system      istiod-85877f7d98-cftnp                                  1/1     Running   0             33m
istio-system      istiod-85877f7d98-qk6rw                                  1/1     Running   0             33m
istio-system      istiod-85877f7d98-rh9kn                                  1/1     Running   0             33m
keda              keda-admission-webhooks-685d94fcff-lqcdg                 1/1     Running   0             31m
keda              keda-operator-65f5568c7b-xpfw5                           1/1     Running   1 (31m ago)   31m
keda              keda-operator-metrics-apiserver-69c577c9cf-ghthq         1/1     Running   0             31m
knative-serving   activator-d66fd5dd8-9phqr                                1/1     Running   0             36m
knative-serving   autoscaler-6c7bf97997-rkd2n                              1/1     Running   0             36m
knative-serving   autoscaler-keda-7f87794cb7-g2wm8                         1/1     Running   0             28m
knative-serving   controller-5b54cd98c-bzgpt                               1/1     Running   0             36m
knative-serving   net-istio-controller-c9444c8ff-rwcp5                     1/1     Running   0             33m
knative-serving   net-istio-webhook-66b6b6444c-zpxjg                       1/1     Running   0             33m
knative-serving   webhook-56ffd84996-ck5tm                                 1/1     Running   0             36m
kube-system       coredns-5dd5756b68-svl4l                                 1/1     Running   0             37m
kube-system       etcd-minikube                                            1/1     Running   0             37m
kube-system       kube-apiserver-minikube                                  1/1     Running   0             37m
kube-system       kube-controller-manager-minikube                         1/1     Running   0             37m
kube-system       kube-proxy-fgj9l                                         1/1     Running   0             37m
kube-system       kube-scheduler-minikube                                  1/1     Running   0             37m
kube-system       storage-provisioner                                      1/1     Running   0             37m

During scaling:

$ kubectl get pod -A
NAMESPACE         NAME                                                     READY   STATUS              RESTARTS      AGE
cert-manager      cert-manager-67c98b89c8-2qvqt                            1/1     Running             0             38m
cert-manager      cert-manager-cainjector-5c5695d979-wbhth                 1/1     Running             0             38m
cert-manager      cert-manager-webhook-7f9f8648b9-22wf5                    1/1     Running             0             38m
default           alertmanager-prometheus-kube-prometheus-alertmanager-0   2/2     Running             0             32m
default           metrics-test-00001-deployment-54b7f678f6-4wttg           2/2     Running             0             15s
default           metrics-test-00001-deployment-54b7f678f6-j8bh8           2/2     Running             0             15s
default           metrics-test-00001-deployment-54b7f678f6-pfhng           2/2     Running             0             26m
default           metrics-test-00001-deployment-54b7f678f6-vc4lg           0/2     ContainerCreating   0             0s
default           metrics-test-00001-deployment-54b7f678f6-wkfmk           0/2     ContainerCreating   0             0s
default           metrics-test-00001-deployment-54b7f678f6-wv27r           0/2     ContainerCreating   0             0s
default           metrics-test-00001-deployment-54b7f678f6-x5kn5           2/2     Running             0             15s
default           metrics-test-00001-deployment-54b7f678f6-xz4fb           0/2     ContainerCreating   0             0s
default           prometheus-grafana-69f9ccfd8d-ztcd7                      3/3     Running             0             32m
default           prometheus-kube-prometheus-operator-6f4fc4dcbd-sz625     1/1     Running             0             32m
default           prometheus-kube-state-metrics-57c8464f66-rlshs           1/1     Running             0             32m
default           prometheus-prometheus-kube-prometheus-prometheus-0       2/2     Running             0             32m
default           prometheus-prometheus-node-exporter-wzcc6                1/1     Running             0             32m
istio-system      istio-ingressgateway-5f8bcfbff9-2sccm                    1/1     Running             0             35m
istio-system      istio-ingressgateway-5f8bcfbff9-q4zbn                    1/1     Running             0             35m
istio-system      istio-ingressgateway-5f8bcfbff9-qhqp5                    1/1     Running             0             35m
istio-system      istiod-85877f7d98-cftnp                                  1/1     Running             0             34m
istio-system      istiod-85877f7d98-qk6rw                                  1/1     Running             0             34m
istio-system      istiod-85877f7d98-rh9kn                                  1/1     Running             0             35m
keda              keda-admission-webhooks-685d94fcff-lqcdg                 1/1     Running             0             32m
keda              keda-operator-65f5568c7b-xpfw5                           1/1     Running             1 (32m ago)   32m
keda              keda-operator-metrics-apiserver-69c577c9cf-ghthq         1/1     Running             0             32m
knative-serving   activator-d66fd5dd8-9phqr                                1/1     Running             0             38m
knative-serving   autoscaler-6c7bf97997-rkd2n                              1/1     Running             0             38m
knative-serving   autoscaler-keda-7f87794cb7-g2wm8                         1/1     Running             0             29m
knative-serving   controller-5b54cd98c-bzgpt                               1/1     Running             0             38m
knative-serving   net-istio-controller-c9444c8ff-rwcp5                     1/1     Running             0             34m
knative-serving   net-istio-webhook-66b6b6444c-zpxjg                       1/1     Running             0             34m
knative-serving   webhook-56ffd84996-ck5tm                                 1/1     Running             0             38m
kube-system       coredns-5dd5756b68-svl4l                                 1/1     Running             0             38m
kube-system       etcd-minikube                                            1/1     Running             0             39m
kube-system       kube-apiserver-minikube                                  1/1     Running             0             39m
kube-system       kube-controller-manager-minikube                         1/1     Running             0             39m
kube-system       kube-proxy-fgj9l                                         1/1     Running             0             38m
kube-system       kube-scheduler-minikube                                  1/1     Running             0             39m
kube-system       storage-provisioner                                      1/1     Running             0             39m

Questions

@skonto would you like me to move forward in this PR and document also injection? I have a version working already, just though of splitting it as I wanted to also document some of those scaling from zero consideration we made on Slack.

/kind documentation
/kind cleanup
/kind enhancement

@knative-prow knative-prow bot added kind/documentation kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 15, 2024
Copy link

linux-foundation-easycla bot commented Nov 15, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: muscionig
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

knative-prow bot commented Nov 15, 2024

Welcome @muscionig! It looks like this is your first PR to knative-extensions/autoscaler-keda 🎉

Copy link

knative-prow bot commented Nov 15, 2024

Hi @muscionig. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2024
@muscionig muscionig force-pushed the feature/istio-doc-and-serving-update branch from 065d2b6 to 7d6fe01 Compare November 15, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation kind/enhancement needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant