-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .spec.secure
field to CRD
#407
Add .spec.secure
field to CRD
#407
Conversation
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 40.02% 40.02%
=======================================
Files 17 17
Lines 742 742
=======================================
Hits 297 297
Misses 441 441
Partials 4 4 |
/cc @pierDipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.11 |
@matzew: new pull request created: #426 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Proposed Changes
.spec.secure
field defined in the GH source type, but don't have it in the CRD:eventing-github/pkg/apis/sources/v1alpha1/githubsource_types.go
Line 84 in ae3b7ca
This PR addresses it and adds it to the CRD.