Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .spec.secure field to CRD #407

Merged

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Sep 19, 2023

Proposed Changes

This PR addresses it and adds it to the CRD.

@knative-prow knative-prow bot requested review from aslom and lberk September 19, 2023 09:41
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #407 (4086f96) into main (ae3b7ca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   40.02%   40.02%           
=======================================
  Files          17       17           
  Lines         742      742           
=======================================
  Hits          297      297           
  Misses        441      441           
  Partials        4        4           

@creydr
Copy link
Contributor Author

creydr commented Sep 20, 2023

/assign @pierDipi @matzew

@creydr
Copy link
Contributor Author

creydr commented Oct 3, 2023

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi October 3, 2023 18:07
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5c96ee6 into knative-extensions:main Oct 4, 2023
14 checks passed
@matzew
Copy link
Contributor

matzew commented Oct 17, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@matzew: new pull request created: #426

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants