Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable random cluster suffix #572

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Re-enable random cluster suffix #572

merged 1 commit into from
Oct 18, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Oct 18, 2023

This patch re-enables random cluster suffix.

/kind cleanup

Release Note

NONE

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 18, 2023
@knative-prow knative-prow bot requested review from jsanin-vmw and kauana October 18, 2023 02:11
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #572 (f9dd7a4) into main (7509cfa) will increase coverage by 0.28%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   72.79%   73.08%   +0.28%     
==========================================
  Files           9        9              
  Lines         691      691              
==========================================
+ Hits          503      505       +2     
+ Misses        159      157       -2     
  Partials       29       29              

see 1 file with indirect coverage changes

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4089d16 into knative-extensions:main Oct 18, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants