Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop v1alpha2 API client #592

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Drop v1alpha2 API client #592

merged 4 commits into from
Dec 1, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Dec 1, 2023

Changes

This patch drops Gateway API v1alpha2 client. The upstream already released GA and v1beta1. v1alpha2 client is no longer necessary.

/kind cleanup

Release Note

NONE

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 1, 2023
@knative-prow knative-prow bot requested review from jsanin-vmw and upodroid December 1, 2023 05:23
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (4eaa9ba) 73.12% compared to head (447cc0c) 73.12%.

Files Patch % Lines
...kg/reconciler/ingress/resources/reference_grant.go 0.00% 11 Missing ⚠️
pkg/reconciler/ingress/reconcile_resources.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files           9        9           
  Lines         692      692           
=======================================
  Hits          506      506           
  Misses        157      157           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3
Copy link
Contributor Author

nak3 commented Dec 1, 2023

The code change is 049db33
Rest of the commits are auto-gen by hack/update-codegen.sh and lint fix in script.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
Copy link

knative-prow bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

ReToCode commented Dec 1, 2023

/override "codecov/patch"

Copy link

knative-prow bot commented Dec 1, 2023

@ReToCode: Overrode contexts on behalf of ReToCode: codecov/patch

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit c070a33 into knative-extensions:main Dec 1, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants