Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang to v1.22 #626

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

dprotaso
Copy link
Contributor

It now uses the reusable action

/assign @izabelacg

Copy link

knative-prow bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2024
@knative-prow knative-prow bot requested review from izabelacg and ReToCode February 22, 2024 22:10
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.12%. Comparing base (d35cd18) to head (7781d3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   73.12%   67.12%   -6.00%     
==========================================
  Files           9       15       +6     
  Lines         692      867     +175     
==========================================
+ Hits          506      582      +76     
- Misses        157      254      +97     
- Partials       29       31       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@@ -53,18 +48,3 @@ jobs:
cluster-resources: nodes,namespaces,crds,gatewayclass
namespace-resources: pods,svc,king,gateway,httproute,referencegrant,tcproute,tlsroute,udproute
artifact-name: logs-${{ matrix.k8s-version}}-${{ matrix.ingress }}

- name: Post failure notice to Slack
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't needed - it was useful when we ran e2e tests periodically in actions

@dprotaso
Copy link
Contributor Author

/override "codecov/project"

Copy link

knative-prow bot commented Feb 22, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit a501be7 into knative-extensions:main Feb 22, 2024
24 of 25 checks passed
@dprotaso dprotaso deleted the bump-go branch February 22, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants