followup changes from #685

[KauzClay]

• addressing PR comments from make service optional in gateway visibility config #685

Changes

• 🧹 clean up stuff based on @dprotaso 's comments on make service optional in gateway visibility config #685

/kind cleanup

Fixes #665

Release Note

N/A

Docs

N/A

[codecov]

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 78.78%. Comparing base (cd525ad) to head (63ddc0e).
Report is 40 commits behind head on main.

Files	Patch %	Lines
pkg/reconciler/ingress/ingress.go	90.90%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #703       +/-   ##
===========================================
+ Coverage   66.97%   78.78%   +11.80%     
===========================================
  Files          15       17        +2     
  Lines         863     1249      +386     
===========================================
+ Hits          578      984      +406     
+ Misses        254      229       -25     
- Partials       31       36        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

/hold for #701

[dprotaso]

/hold cancel

other PR merged - but you'll need to rebase

[dprotaso]

just need a minor change in an error message

[dprotaso]

/lgtm
/approve

thanks for the cleanup

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KauzClay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/override "Generate some code!"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"

[knative-prow]

@dprotaso: Overrode contexts on behalf of dprotaso: Generate some code!, style / suggester / github_actions, style / suggester / yaml

In response to this:

/override "Generate some code!"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.