Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Contour's Envoy as a Deployment #704

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

dprotaso
Copy link
Contributor

I think overall this is more flexible than a daemonset

Copy link

knative-prow bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@knative-prow knative-prow bot requested review from izabelacg and ReToCode April 22, 2024 18:17
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.69%. Comparing base (cd525ad) to head (cd1a705).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   66.97%   76.69%   +9.71%     
==========================================
  Files          15       16       +1     
  Lines         863     1197     +334     
==========================================
+ Hits          578      918     +340     
+ Misses        254      234      -20     
- Partials       31       45      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@dprotaso
Copy link
Contributor Author

/override "Generate some code!"
/override "style / suggester / shell"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"
/override "style / Golang"

Workaround for prow merging being broken - knative/infra#411

Copy link

knative-prow bot commented Apr 22, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: Generate some code!, style / Golang, style / suggester / github_actions, style / suggester / shell, style / suggester / yaml

In response to this:

/override "Generate some code!"
/override "style / suggester / shell"
/override "style / suggester / yaml"
/override "style / suggester / github_actions"
/override "style / Golang"

Workaround for prow merging being broken - knative/infra#411

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit d5c5842 into knative-extensions:main Apr 22, 2024
30 checks passed
@dprotaso dprotaso deleted the contour-deployment branch April 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants