Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sigs.k8s.io/gateway-api@main #709

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Apr 23, 2024

This bumps gateway-api dependency to their latest main - their v1.1 release will be out tomorrow so this captures more or less all the changes there.

@knative-prow knative-prow bot requested a review from cardil April 23, 2024 15:02
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@knative-prow knative-prow bot requested a review from skonto April 23, 2024 15:02
Copy link

knative-prow bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@dprotaso
Copy link
Contributor Author

overriding the failed actions because review dog can't handle the diff size
/override "Generate some code!"
/override "style / Golang / Lint"
/override "style / suggester / yaml"
/override "style / suggester / shell"
/override "style / suggester / github_actions"
/override "style / Golang / Boilerplate Check (sh)"
/override "style / Golang / Boilerplate Check (go)"
/override "style / Golang / Do Not Submit"

Copy link

knative-prow bot commented Apr 23, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: Generate some code!, style / Golang / Boilerplate Check (go), style / Golang / Boilerplate Check (sh), style / Golang / Do Not Submit, style / Golang / Lint, style / suggester / github_actions, style / suggester / shell, style / suggester / yaml

In response to this:

overriding the failed actions because review dog can't handle the diff size
/override "Generate some code!"
/override "style / Golang / Lint"
/override "style / suggester / yaml"
/override "style / suggester / shell"
/override "style / suggester / github_actions"
/override "style / Golang / Boilerplate Check (sh)"
/override "style / Golang / Boilerplate Check (go)"
/override "style / Golang / Do Not Submit"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@knative-prow knative-prow bot merged commit 11b15b9 into knative-extensions:main Apr 23, 2024
29 of 35 checks passed
@dprotaso dprotaso deleted the bump-gateway branch April 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants