-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow the config-gateway to accepted supported features #710
allow the config-gateway to accepted supported features #710
Conversation
This allows us to use experimental features safely
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
===========================================
+ Coverage 66.97% 77.31% +10.33%
===========================================
Files 15 17 +2
Lines 863 1265 +402
===========================================
+ Hits 578 978 +400
+ Misses 254 249 -5
- Partials 31 38 +7 ☔ View full report in Codecov by Sentry. |
/assign @izabelacg |
/lgtm |
/override "Generate some code!" |
@dprotaso: Overrode contexts on behalf of dprotaso: Generate some code!, style / suggester / github_actions In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This allows us to use experimental features safely
I've added
HTTPRouteRequestTimeout
to Contour and Istio configs because they support it. See the reports here: https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/reports/v1.0.0