Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followup from #703: check error type properly #714

Merged

Conversation

KauzClay
Copy link
Contributor

Changes

  • 🧹 use errors.Is()

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Apr 23, 2024

@KauzClay: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 use errors.Is()

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2024
@knative-prow knative-prow bot requested review from dprotaso and ReToCode April 23, 2024 18:22
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (cd525ad) to head (b3340d3).
Report is 51 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #714       +/-   ##
===========================================
+ Coverage   66.97%   79.12%   +12.15%     
===========================================
  Files          15       17        +2     
  Lines         863     1260      +397     
===========================================
+ Hits          578      997      +419     
+ Misses        254      227       -27     
- Partials       31       36        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KauzClay KauzClay changed the title [wip] followup from #703: check error type properly followup from #703: check error type properly Apr 23, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
Copy link

knative-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KauzClay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@knative-prow knative-prow bot merged commit bc80527 into knative-extensions:main May 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants