Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump gateway-api to v1.1 #729

Closed
wants to merge 3 commits into from
Closed

bump gateway-api to v1.1 #729

wants to merge 3 commits into from

Conversation

dprotaso
Copy link
Contributor

/assign @izabelacg

@knative-prow Knative Prow
Copy link

knative-prow bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@knative-prow knative-prow bot requested review from krsna-m, skonto and upodroid May 17, 2024 20:08
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 17, 2024
@dprotaso
Copy link
Contributor Author

/test integration-tests-contour_net-gateway-api_main

@knative-prow Knative Prow
Copy link

knative-prow bot commented May 17, 2024

@dprotaso: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests-contour_net-gateway-api_main baa803c link true /test integration-tests-contour

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dprotaso dprotaso force-pushed the bump-gateway-api branch from baa803c to b558d3f Compare May 17, 2024 21:10
@dprotaso dprotaso force-pushed the bump-gateway-api branch from 75ce0d5 to 9ee97c6 Compare May 17, 2024 21:38
@dprotaso
Copy link
Contributor Author

It seems like contour is broken when you install gateway api v1.1. crds and the v1.29.0 provisioner. I'm going to close this for now

@dprotaso dprotaso closed this May 17, 2024
@dprotaso dprotaso mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krsna-m krsna-m Awaiting requested review from krsna-m

@skonto skonto Awaiting requested review from skonto

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@izabelacg izabelacg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dprotaso @izabelacg