Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add envoy gateway testing #738

Merged
merged 12 commits into from
Jun 18, 2024
Merged

Add envoy gateway testing #738

merged 12 commits into from
Jun 18, 2024

Conversation

dprotaso
Copy link
Contributor

Part of #566

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2024
@knative-prow knative-prow bot requested review from cardil, ReToCode and upodroid May 31, 2024 20:25
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2024
@dprotaso dprotaso force-pushed the envoy-gateway-support branch from 170f3dc to 621c2ba Compare May 31, 2024 20:41
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2024
@dprotaso
Copy link
Contributor Author

/test integration-tests-envoy-gateway_net-gateway-api_main
/test integration-tests-envoy-gateway-conformance_net-gateway-api_main

@codecov Codecov
Copy link

codecov bot commented May 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (1058d9e) to head (2d6aa8e).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files          17       17           
  Lines        1260     1260           
=======================================
  Hits          997      997           
  Misses        227      227           
  Partials       36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Contributor Author

/test integration-tests-envoy-gateway_net-gateway-api_main
/test integration-tests-envoy-gateway-conformance_net-gateway-api_main

arkodg
arkodg reviewed Jun 3, 2024
View reviewed changes
hack/test-env.sh Outdated Show resolved Hide resolved
@dprotaso dprotaso force-pushed the envoy-gateway-support branch from 31453e7 to 2b9d0de Compare June 3, 2024 20:35
@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 3, 2024

/test integration-tests-envoy-gateway_net-gateway-api_main
/test integration-tests-envoy-gateway-conformance_net-gateway-api_main

@dprotaso dprotaso force-pushed the envoy-gateway-support branch from 2b9d0de to eff3a5e Compare June 3, 2024 21:11
@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 3, 2024

gateway isn't getting and addresss

    conditions:
    - lastTransitionTime: "2024-06-03T21:22:55Z"
      message: The Gateway has been scheduled by Envoy Gateway
      observedGeneration: 1
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2024-06-03T21:22:55Z"
      message: No addresses have been assigned to the Gateway
      observedGeneration: 1
      reason: AddressNotAssigned
      status: "False"
      type: Programmed

arkodg added a commit to arkodg/gateway that referenced this pull request Jun 3, 2024
@arkodg
api: support user provided names for generated k8s resources
c84ebf1 
* Users prefer setting their own custom names for generated
k8s resources for the Envoy Proxy fleet instead of the autogenerated
resources
  * https://envoyproxy.slack.com/archives/C03E6NHLESV/p1717068088779319
  * knative-extensions/net-gateway-api#738
  * envoyproxy#2141

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this pull request Jun 3, 2024
Merged
@arkodg
Copy link

arkodg commented Jun 3, 2024

hey @dprotaso can we kick CI once, to see if this is a flake or something that just doesnt work in this setup ? setting the Gateway.Status.Addresses from the Svc is something that is verified in the conformance tests, so not sure why its not working here

@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 3, 2024 via email

@arkodg arkodg mentioned this pull request Jun 3, 2024
Closed
@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 3, 2024 via email

zirain pushed a commit to envoyproxy/gateway that referenced this pull request Jun 4, 2024
@arkodg
api: support user provided names for generated k8s resources (#3527)
6d0bc1f 
* Users prefer setting their own custom names for generated
k8s resources for the Envoy Proxy fleet instead of the autogenerated
resources
  * https://envoyproxy.slack.com/archives/C03E6NHLESV/p1717068088779319
  * knative-extensions/net-gateway-api#738
  * #2141

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this pull request Jun 5, 2024
Merged
@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 7, 2024

/test integration-tests-envoy-gateway_net-gateway-api_main
/test integration-tests-envoy-gateway-conformance_net-gateway-api_main

@dprotaso dprotaso force-pushed the envoy-gateway-support branch from 3569e50 to cfa1c09 Compare June 18, 2024 17:22
@dprotaso
Copy link
Contributor Author

/test integration-tests-envoy-gateway_net-gateway-api_main
/test integration-tests-envoy-gateway-conformance_net-gateway-api_main

@dprotaso dprotaso force-pushed the envoy-gateway-support branch from cfa1c09 to 0d57fe1 Compare June 18, 2024 18:11
@dprotaso
Copy link
Contributor Author

/test integration-tests-envoy-gateway_net-gateway-api_main
/test integration-tests-envoy-gateway-conformance_net-gateway-api_main

I believe the failure is GKE related - similar to: #708

@dprotaso dprotaso changed the title [wip] add envoy gateway Add envoy gateway Jun 18, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2024
@dprotaso dprotaso changed the title Add envoy gateway Add envoy gateway testing Jun 18, 2024
@dprotaso
Copy link
Contributor Author

@arkodg all good now

/assign @izabelacg

cc @ReToCode @skonto

@dprotaso
Copy link
Contributor Author

Note we're testing the latest release - we'll want to pin it down when they release their next release

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@knative-prow knative-prow bot merged commit cf4988a into knative-extensions:main Jun 18, 2024
33 checks passed
@dprotaso dprotaso deleted the envoy-gateway-support branch June 18, 2024 19:49
@dprotaso dprotaso mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg left review comments

@cardil cardil Awaiting requested review from cardil

@ReToCode ReToCode Awaiting requested review from ReToCode

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@izabelacg izabelacg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @arkodg @izabelacg @knative-prow-robot