Skip to content

Commit

Permalink
bump version to 1.30 again
Browse files Browse the repository at this point in the history
  • Loading branch information
skonto committed Dec 20, 2024
1 parent ed337a0 commit 17feba1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const (
// NOTE: If you are changing this line, please also update the minimum kubernetes
// version listed here:
// https://github.com/knative/docs/blob/main/docs/snippets/prerequisites.md
defaultMinimumVersion = "v1.29.0"
defaultMinimumVersion = "v1.30.0"
)

func getMinimumVersion() string {
Expand Down
10 changes: 5 additions & 5 deletions version/version_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func TestVersionCheck(t *testing.T) {
wantError bool
}{{
name: "greater version (patch)",
actualVersion: &testVersioner{version: "v1.29.1"},
actualVersion: &testVersioner{version: "v1.30.1"},
}, {
name: "greater version (patch), no v",
actualVersion: &testVersioner{version: "1.30.1"},
Expand All @@ -60,16 +60,16 @@ func TestVersionCheck(t *testing.T) {
versionOverride: "1.15.11-0",
}, {
name: "greater version (minor)",
actualVersion: &testVersioner{version: "v1.29.0"},
actualVersion: &testVersioner{version: "v1.30.0"},
}, {
name: "same version",
actualVersion: &testVersioner{version: "v1.29.0"},
actualVersion: &testVersioner{version: "v1.30.0"},
}, {
name: "same version with build",
actualVersion: &testVersioner{version: "v1.29.0+k3s.1"},
actualVersion: &testVersioner{version: "v1.30.0+k3s.1"},
}, {
name: "same version with pre-release",
actualVersion: &testVersioner{version: "v1.29.0-k3s.1"},
actualVersion: &testVersioner{version: "v1.30.0-k3s.1"},
}, {
name: "smaller version",
actualVersion: &testVersioner{version: "v1.14.3"},
Expand Down

0 comments on commit 17feba1

Please sign in to comment.