chore(all): fixed lint issues

knowii-oss · Sep 6, 2024 · 1bf06a1 · 1bf06a1
1 parent 4e713a7
commit 1bf06a1
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 13 deletions.
diff --git a/apps/knowii/.eslintrc.json b/apps/knowii/.eslintrc.json
@@ -4,7 +4,9 @@
   "overrides": [
     {
       "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
-      "rules": {}
+      "rules": {
+        "@nx/enforce-module-boundaries": 0
+      }
     },
     {
       "files": ["*.ts", "*.tsx"],

diff --git a/apps/knowii/src/Components/Banner.tsx b/apps/knowii/src/Components/Banner.tsx
@@ -75,8 +75,8 @@ export default function Banner() {
                 <button
                   type="button"
                   className={classNames('-mr-1 flex p-2 rounded-md focus:outline-none sm:-mr-2 transition', {
-                    'hover:bg-indigo-600 focus:bg-indigo-600': style == 'success',
-                    'hover:bg-red-600 focus:bg-red-600': style == 'danger',
+                    'hover:bg-indigo-600 focus:bg-indigo-600': style === 'success',
+                    'hover:bg-red-600 focus:bg-red-600': style === 'danger',
                   })}
                   aria-label="Dismiss"
                   onClick={(e) => {

diff --git a/apps/knowii/src/Pages/Auth/Register.tsx b/apps/knowii/src/Pages/Auth/Register.tsx
@@ -135,19 +135,22 @@ export default function Register() {
                     id="terms"
                     checked={form.data.terms}
                     onChange={(e) => {
-                      // @ts-expect-error
-                      form.setData('terms', e.target.checked);
+                      if (e.target && e.target.checked === true) {
+                        form.setData('terms', true);
+                      } else {
+                        form.setData('terms', false);
+                      }
                     }}
                     required
                   />
 
                   <div className="ml-2">
                     I agree to the&nbsp;
-                    <a target="_blank" href={route(TERMS_OF_SERVICE_URL)} className="simple-link">
+                    <a target="_blank" rel="noreferrer" href={route(TERMS_OF_SERVICE_URL)} className="simple-link">
                       Terms of Service&nbsp;
                     </a>
                     and&nbsp;
-                    <a target="_blank" href={route(PRIVACY_POLICY_URL)} className="simple-link">
+                    <a target="_blank" rel="noreferrer" href={route(PRIVACY_POLICY_URL)} className="simple-link">
                       Privacy Policy
                     </a>
                   </div>

diff --git a/apps/knowii/src/Pages/Welcome.tsx b/apps/knowii/src/Pages/Welcome.tsx
@@ -37,7 +37,12 @@ export default function Welcome(props: WelcomePageProps) {
 
         <PageContentWrapper>
           <div className="flex flex-col items-center">
-            <h1 className="text-primary-500">Welcome&nbsp;👋</h1>
+            <h1 className="text-primary-500">
+              Welcome&nbsp;
+              <span role={'img'} aria-label="waving hand">
+                👋
+              </span>
+            </h1>
             <h2 className="mt-4">
               Know<span className="text-primary-500">ii</span> is a place for your community's Knowledge, Ideas and Inspiration.
             </h2>

diff --git a/apps/knowii/src/main.tsx b/apps/knowii/src/main.tsx
@@ -30,4 +30,6 @@ createInertiaApp({
   progress: {
     color: '#4B5563',
   },
-}).then((_createdApp) => {});
+}).then((_createdApp) => {
+  console.log('Welcome to Knowii ❤️');
+});
diff --git a/apps/knowii/tailwind.config.ts b/apps/knowii/tailwind.config.ts
@@ -1,12 +1,11 @@
 import type { Config } from 'tailwindcss';
-const { createGlobPatternsForDependencies } = require('@nx/react/tailwind');
-const { join } = require('path');
+import { createGlobPatternsForDependencies } from '@nx/react/tailwind';
+import { join } from 'path';
+import { theme } from './src/theme.mjs';
 import defaultTheme from 'tailwindcss/defaultTheme';
 import forms from '@tailwindcss/forms';
 import typography from '@tailwindcss/typography';
 
-import { theme } from './src/theme.mjs';
-
 /** @type {import('tailwindcss').Config} */
 export default {
   content: [