Parser #455
Merged
Parser #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarx
reviewed
Mar 19, 2024
nemo/src/io/parser.rs
Outdated
Comment on lines
2447
to
2448
| // SAFETY: The concatenation of strings is okay, because they originated from the same source string. | ||
| // The raw offset is okay, because the offset of another span is used. |
There was a problem hiding this comment.
pretty sure this is unsound, since the requirement that the two spans are from the same allocation is not actually enforced anywhere. As such, combine_spans should itself be unsafe.
mmarx
reviewed
May 15, 2024
nemo/src/io/lexer.rs
Outdated
| @@ -166,6 +222,7 @@ impl std::fmt::Display for TokenKind { | |||
| TokenKind::PrefixIdent => write!(f, "PrefixIdent"), | |||
| TokenKind::Illegal => write!(f, "Illegal"), | |||
| TokenKind::Eof => write!(f, "Eof"), | |||
| TokenKind::Error => write!(f, "\x1b[1;31mError\x1b[0m"), | |||
There was a problem hiding this comment.
Please don't use raw escape sequences, and also don't colour unconditionally. In nemo-cli we already use colored::Colorize for this, which handles, e.g., the NO_COLOR environment variable and terminal capabilities.
…rals into NegativeAtom
aannleax
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #466.
Closes #465.
Closes #447.
Closes #443.
Closes #346.
Closes #219.
Closes #539.
Closes #522.