Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to ignore DSV headers #586

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add option to ignore DSV headers #586

merged 1 commit into from
Jan 9, 2025

Conversation

mmarx
Copy link
Member

@mmarx mmarx commented Jan 9, 2025

Add an ignore_headers attribute to @import directives that drops the first record in DSV sources.

@mmarx mmarx added enhancement New feature or request CSV CSV-Related Issue io labels Jan 9, 2025
@mmarx mmarx added this to the Release 0.7.0 milestone Jan 9, 2025
@mmarx mmarx requested a review from matzemathics January 9, 2025 15:07
@mmarx mmarx self-assigned this Jan 9, 2025
matzemathics
matzemathics approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@matzemathics matzemathics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Even a negative diff 👍

@mmarx mmarx force-pushed the feature/dsv-ignore-headers branch from 6f3578b to 2c005c0 Compare January 9, 2025 15:16
@mmarx mmarx merged commit 1f2a676 into main Jan 9, 2025
8 checks passed
@mmarx mmarx deleted the feature/dsv-ignore-headers branch January 9, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzemathics matzemathics matzemathics approved these changes

Assignees

@mmarx mmarx

Labels
CSV CSV-Related Issue enhancement New feature or request io
Projects
nemo
Status: Done
Milestone
Release 0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mmarx @matzemathics