Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bdd features and scenarios #14

Merged
merged 11 commits into from
Oct 13, 2015
Merged

Bdd features and scenarios #14

merged 11 commits into from
Oct 13, 2015

Conversation

bocharsky-bw
Copy link
Member

Resolve 02-bdd-features and 03-scenarios in #12

@bocharsky-bw
Copy link
Member Author

Do you have 03-scenarios challenges already?


public function grade(CodingExecutionResult $result)
{
throw new GradingException('Oops...');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverryan I wondering how to grade features. There're any best solution for it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we do some basic parsing to make sure their format is correct - I.e. they have "in order to", "as a", etc. there's a new gherkin execution mode I added to activity-runner, which basically renders no output (it doesn't have anything to help with parsing gherkin though)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also to chech the correct order of "in order to", "as a", etc.?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so - e.g line 1 should be Feature:, line 2 In order to, etc

weaverryan added a commit that referenced this pull request Oct 13, 2015
@weaverryan weaverryan merged commit 6ba8fd5 into behat3 Oct 13, 2015
@weaverryan weaverryan deleted the bdd-features-and-scenarios branch October 13, 2015 00:10
@weaverryan
Copy link
Member

@bocharsky-bw I finished everything through 03. Sorry about not having the challenges ready for 03 - I thought I had added them, but I did not. I'll add more challenges soon for the other chapters.

But hey... first chapters are now live :)

@bocharsky-bw
Copy link
Member Author

@weaverryan OK, I could still work with code blocks now.

And now I have an illustrative example how to grade challenges :)

BTW, we could use RegEx to grade more complex things in the future.

@weaverryan
Copy link
Member

I'm fine with Regex, I'm not great at it personally, and sometimes it can make things less readable (because you really need to understand regex to understand what the code is doing). But in general, I'm definitely cool with using regex when it makes sense.

And yes - code blocks would be awesome for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants