Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code blocks to the ch16 (get-authenticated-user) #29

Merged
merged 1 commit into from
Nov 13, 2015

Conversation

bocharsky-bw
Copy link
Member

Resolve 16-get-authenticated-user in #12

"I" author some products. To share data between steps, create a new `private $currentUser;`.
"I" author some products. To share data between steps, create a new `private $currentUser;`:

[[[ code('100d047bcd') ]]]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverryan Should we add more context here and wrap this property with class in the code block? I show a single line of property declaration here in code block now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

weaverryan added a commit that referenced this pull request Nov 13, 2015
Add code blocks to the ch16 (get-authenticated-user)
@weaverryan weaverryan merged commit 608c74b into behat3 Nov 13, 2015
@weaverryan weaverryan deleted the code-blocks-ch16 branch November 13, 2015 16:56

In `iAmLoggedInAsAnAdmin()`, add `$this->currentUser = $this->thereIsAnAdminUserWithPassword()`:

[[[ code('9d15e806ff') ]]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this more context too - it was just the single line, I expanded it to show the method name above (and the opening { and close } after it.

@bocharsky-bw
Copy link
Member Author

@weaverryan Thanks for this review, it was very useful! I got the idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants