Show enum case name in output #874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 I didn't get the chance to look at this, but it seems like a good idea. Still interested? |
|
If you can't reopen it, I would gladly redo it |
shalvah
reviewed
Sep 15, 2024
| @@ -90,7 +90,7 @@ enum_exists($enum) && method_exists($enum, 'tryFrom') | |||
| // $case->value only exists on BackedEnums, not UnitEnums | |||
| // method_exists($enum, 'tryFrom') implies $enum instanceof BackedEnum | |||
| // @phpstan-ignore-next-line | |||
| $rulesList[] = 'in:' . implode(',', array_map(fn ($case) => $case->value, $enum::cases())); | |||
| $rulesList[] = 'in:' . implode(',', array_map(fn ($case) => "$case->value ($case->name)", $enum::cases())); | |||
There was a problem hiding this comment.
Please delete this line because it's not needed. The rulesList is the actual list of rules that Laravel supports, and changing this from in:1,2,3 to in:1 (MALE),2 (FEMALE),3 (UNDEFINED) will probably break things.
shalvah
reviewed
Sep 15, 2024
Comment on lines
+212
to
+218
| $cases = []; | ||
| foreach ($type::cases() as $case) { | ||
| /** @var BackedEnum $case */ | ||
| $cases[$case->name] = $case->value; | ||
| } | ||
|
|
||
| $parameterData['type'] = gettype(reset($cases)); |
There was a problem hiding this comment.
Hmm, what does this do? The $cases array is not used for anything else beyond getting the type, and it does the same thing as the previous version, which works for Backed Enums.
shalvah
reviewed
Sep 15, 2024
|
I can't reopen it, as the repository has been deleted. 😞 Please redo if you can (but see my comments). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where BackedEnums have int type, the output is just a list of numbers, ex:
With this changes, enums with int type will show the base name of the case: